-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix missing text after code blocks and missing code blocks, in @vscode responses #1258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
LGTM. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes two critical issues with the @vscode
participant's response processing: missing text after code blocks and disappearing non-JSON code blocks. The fix ensures that all text content is properly displayed to users and that non-JSON code blocks are shown rather than being processed for settings/commands.
- Refactors the code block processing logic to properly handle text before and after code blocks
- Updates the parsing logic to skip non-JSON code blocks instead of trying to process them
- Removes unused properties from the VSCodeParticipantMetadata interface
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
File | Description |
---|---|
src/extension/intents/node/vscodeIntent.ts | Refactors processNonReporting method and applyDelta method to properly handle text surrounding code blocks and ensure all content is displayed |
src/extension/context/node/resolvers/vscodeContext.ts | Updates parseSettingsAndCommands function to return empty array for non-JSON blocks and removes unused showCodeBlock and codeBlock properties |
src/extension/context/node/resolvers/test/vscodeContext.spec.ts | Adds comprehensive test suite covering various scenarios for the updated parsing logic |
Fix for issues appearing in microsoft/vscode#269351 (comment).
@vscode
participantAlso cleans up unused properties
showCodeBlock
andcodeBlock