Incorrect indentation for if statements without curly braces

[osalbahr]

Environment

• OS and Version: Fedora Linux 43 (Workstation Edition Prerelease) x86_64
• VS Code Version: 1.105.0-insider
• C/C++ Extension Version: 1.28.0
• If using SSH remote, specify OS of remote machine: N/A

Bug Summary and Steps to Reproduce

Bug Summary:

In C/C++, creating an if/for/while without curly braces results in no further indentation.

Steps to reproduce:

1. Open a directory and trust it
2. Open a hello.c file
3. Create an if statement
4. Press enter

Expected behavior:

Further indentation.

Configuration and Logs

N/A

Other Extensions

Only the C/C++ extension pack on a newly installed code-insiders.

Additional context

#include <stdio.h>

int main()
{
    if (1)
    puts("Test");
}

[sean-mcmanus]

@osalbahr I don't repro the issue. Can you set C_Cpp.loggingLevel to "Debug" and look at the C/C++ output after formatting to see if it's doing clangFormat or vcFormat and if there are any errors? And the issue might be caused by your formatting settings, etc.

[sean-mcmanus]

@osalbahr Oh, I figured it out -- you're not running the formatting. Our extension doesn't automatically indent after an "if". You need to run the formatter.

[osalbahr]

@sean-mcmanus No, I'm not running the formatter. The formatter works as expected. So I guess this is a bug in VS Code itself, not the extension. If so, where should I file this bug?

[sean-mcmanus]

@osalbahr It's "by design". It works as you describe if you set

    "C_Cpp.formatting": "vcFormat",
    "editor.formatOnType": true,

[sean-mcmanus]

@osalbahr You could try filing a Vs code bug, but I believe they would close it as being an extension issue since I don't think VS Code itself handles auto-indentation after a newline. We had an old issue tracking this at #883