ESLint@^8 cannot format the code when saving

[vvizden]

Hi,
After my test, ESLint@^8 cannot format the code when saving with the following configuration, and versions ^5 to ^7 do fine.

"editor.codeActionsOnSave": {
    "source.fixAll.eslint": true
}

I don't know if this issue is reported to eslint or vscode-eslint.

[MariaSolOs]

Try setting "eslint.format.enable": true

[vvizden]

Try setting "eslint.format.enable": true

Doesn't seem to work.

[dbaeumer]

What happens when running ESLint in the terminal on the same file with --fix. Will it be fixed. If yes, can you then please provide me with a GitHub repository I can clone that demos what you are seeing.

We use ESLint 8 in day-to-day developement as well and format on save works for us (doesn't mean that there is not a bug somewhere, but I need to be able to reproduce it)

[vvizden]

What happens when running ESLint in the terminal on the same file with --fix. Will it be fixed. If yes, can you then please provide me with a GitHub repository I can clone that demos what you are seeing.

We use ESLint 8 in day-to-day developement as well and format on save works for us (doesn't mean that there is not a bug somewhere, but I need to be able to reproduce it)

@dbaeumer Here https://github.com/vvizden/vscode-eslint8-saving, please check the index.js in the repo.

About VSCode:

• Version: 1.73.0 (Universal)
• Commit: 8fa188b2b301d36553cbc9ce1b0a146ccb93351f
• Date: 2022-11-01T15:38:50.881Z
• Electron: 19.0.17
• Chromium: 102.0.5005.167
• Node.js: 16.14.2
• V8: 10.2.154.15-electron.0
• OS: Darwin x64 22.1.0
• Sandboxed: No

About VSCode Plugins:

• VSCode ESLint v2.2.6
• VSCode Prettier v9.9.0

[MariaSolOs]

@vvizden Your repro doesn't seem to include a settings.json file. Is that intentional?

[vvizden]

@vvizden Your repro doesn't seem to include a settings.json file. Is that intentional?

@MariaSolOs I used the VSCode user settings and now I've submitted the settings.json.

[vvizden]

@MariaSolOs You reminded me, and I found the reason through the binary comment in my user settings.json file.
Seems because of this config:

"eslint.codeActionsOnSave.rules": [],

But why is versions ^5 to ^7 not affected by it.

[MariaSolOs]

@vvizden I just cloned your repo and everything worked for me.

Seems because of this config:
"eslint.codeActionsOnSave.rules": [],

That makes sense. That setting lists the rules that should be auto-fixed when saving/formatting a file. If it's empty, the extension will not make any changes. If not defined, then the default is to use the rules in the .eslintrc file.

But why is versions ^5 to ^7 not affected by it.

Good question. The README says:

So what I think was happening is that with earlier versions of ESLint this extension would just ignore your "eslint.codeActionsOnSave.rules": [] setting, but now that you've upgraded to v8 it results in the behavior explained above.

[vvizden]

Thank you very much for the careful answer, and here is a summary to help friends who encounter the same problem.

Solve this problem quickly：

It doesn't matter which version of eslint ( now the latest version is 8.27.0 ) in package.json, just remove the "eslint.codeActionsOnSave.rules": [] in your VSCode settings.json.