Skip to content

ci: jdk compile support jdk 24 #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 7, 2025
Merged

ci: jdk compile support jdk 24 #886

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6d4941c
ci: jdk compile support jdk 24
wenytang-ms Aug 7, 2025
14a1b22
Update scripts/buildJdtlsExt.js
wenytang-ms Aug 7, 2025
d1bf2b0
ci: update
wenytang-ms Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion scripts/buildJdtlsExt.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,19 @@ const path = require('path');

const server_dir = path.resolve('jdtls.ext');

cp.execSync(mvnw()+ ' clean package', {cwd:server_dir, stdio:[0,1,2]} );
// Set JVM options to increase XML entity size limits
// JDK 24 contains changes to JAXP limits, see: https://bugs.openjdk.org/browse/JDK-8343022
const jvmOptions = [
'-Djdk.xml.maxGeneralEntitySizeLimit=0',
'-Djdk.xml.totalEntitySizeLimit=0'
].join(' ');

// Set MAVEN_OPTS environment variable with JVM options
const env = { ...process.env };
env.MAVEN_OPTS = env.MAVEN_OPTS ? env.MAVEN_OPTS + ' ' + jvmOptions : jvmOptions;

const mvnCommand = `${mvnw()} clean package`;
cp.execSync(mvnCommand, {cwd:server_dir, stdio:[0,1,2], env: env} );
copy(path.join(server_dir, 'com.microsoft.jdtls.ext.core/target'), path.resolve('server'), (file) => {
return /^com.microsoft.jdtls.ext.core.*.jar$/.test(file);
});
Expand Down
Loading