Skip to content

fix: normalize path for UI display when removing virtual environments #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 22, 2025
Merged

fix: normalize path for UI display when removing virtual environments #853

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4778ba
fix: normalize path for UI display when removing virtual environments
eleanorjboyd Sep 21, 2025
8a702ad
Merge branch 'main' into sunny-lark
eleanorjboyd Sep 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/managers/builtin/venvUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import { getWorkspacePersistentState } from '../../common/persistentState';
import { pickEnvironmentFrom } from '../../common/pickers/environments';
import { EventNames } from '../../common/telemetry/constants';
import { sendTelemetryEvent } from '../../common/telemetry/sender';
import { normalizePath } from '../../common/utils/pathUtils';
import {
showErrorMessage,
showInputBox,
Expand Down Expand Up @@ -501,8 +502,11 @@ export async function removeVenv(environment: PythonEnvironment, log: LogOutputC
? path.dirname(path.dirname(environment.environmentPath.fsPath))
: environment.environmentPath.fsPath;

// Normalize path for UI display - ensure forward slashes on Windows
const displayPath = normalizePath(envPath);

const confirm = await showWarningMessage(
l10n.t('Are you sure you want to remove {0}?', envPath),
l10n.t('Are you sure you want to remove {0}?', displayPath),
{
modal: true,
},
Expand All @@ -529,7 +533,7 @@ export async function removeVenv(environment: PythonEnvironment, log: LogOutputC
return result;
}

traceInfo(`User cancelled removal of virtual environment: ${envPath}`);
traceInfo(`User cancelled removal of virtual environment: ${displayPath}`);
return false;
}

Expand Down
Loading