Skip to content

Conversation

@anthonykim1
Copy link
Contributor

@anthonykim1 anthonykim1 commented Oct 1, 2025

Resolves: #865
If user modifies already existing shell profile script needed for shell startup, they get stuck into not activating state because they still have auto activation guard, which blocks shell integration from core from activating.

This also means because they have wrong env var in profile script, it won't activate there either.
We should better track this, and properly clean up profile script when relying on shell integration for activation.

/cc @karthiknadig

@anthonykim1 anthonykim1 self-assigned this Oct 1, 2025
@anthonykim1 anthonykim1 added the bug Issue identified by VS Code Team member as probable bug label Oct 1, 2025
@anthonykim1 anthonykim1 marked this pull request as ready for review October 1, 2025 23:25
@vs-code-engineering vs-code-engineering bot added this to the September 2025 milestone Oct 1, 2025
@anthonykim1 anthonykim1 enabled auto-merge (squash) October 1, 2025 23:27
@anthonykim1 anthonykim1 merged commit b6bb205 into main Oct 1, 2025
11 checks passed
@anthonykim1 anthonykim1 deleted the anthonykim1/shellStartupFixes branch October 1, 2025 23:43
eleanorjboyd pushed a commit to eleanorjboyd/vscode-python-environments that referenced this pull request Oct 8, 2025
…crosoft#880)

Resolves:
microsoft#865
If user modifies already existing shell profile script needed for shell
startup, they get stuck into not activating state because they still
have auto activation guard, which blocks shell integration from core
from activating.

This also means because they have wrong env var in profile script, it
won't activate there either.
We should better track this, and properly clean up profile script when
relying on shell integration for activation.

/cc @karthiknadig
NguyenCuong1989 referenced this pull request in NguyenCuong1989/vscode-python-environments Oct 23, 2025
Resolves:
microsoft/vscode-python-environments#865
If user modifies already existing shell profile script needed for shell
startup, they get stuck into not activating state because they still
have auto activation guard, which blocks shell integration from core
from activating.

This also means because they have wrong env var in profile script, it
won't activate there either.
We should better track this, and properly clean up profile script when
relying on shell integration for activation.

/cc @karthiknadig
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue identified by VS Code Team member as probable bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

shellStartup does not activate when in WSL

3 participants