fix env var clearing #886
Merged
fix env var clearing #886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eleanorjboyd
force-pushed
the
xenacious-baboon
branch
from
ab490c2 to
48fc434
Compare
eleanorjboyd
added
the
bug
anthonykim1
approved these changes
Oct 2, 2025
anthonykim1
reviewed
Oct 2, 2025
| await this.injectEnvironmentVariablesForWorkspace(workspaceFolder); | ||
| } else { | ||
| // No provided workspace - update all workspaces | ||
| this.envVarCollection.clear(); |
There was a problem hiding this comment.
I dont know about this one though, I think we should still clear if in no workspace scenario.
eleanorjboyd
added a commit
to eleanorjboyd/vscode-python-environments
that referenced
this pull request
Oct 8, 2025
NguyenCuong1989
referenced
this pull request
in NguyenCuong1989/vscode-python-environments
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #883