Rework to automatically convert old settings

Author: marsfan

news/2 Fixes/410.md

@@ -1,14 +1,11 @@
 # Replaced occuances of `pep8` with `pycodestyle.`
-## Add new settings:
-* python.linting.pycodestyleArgs
-* python.linting.pycodestyleCategorySeverity.E
-* python.linting.pycodestyleCategorySeverity.W
-* python.linting.pycodestyleEnabled
-* python.linting.pycodestylePath
-## Add depreciation warnings for:
-* python.linting.pep8Args
-* python.linting.pep8CategorySeverity.E
-* python.linting.pep8CategorySeverity.W
-* python.linting.pep8Enabled
-* python.linting.pep8Path
 
+All menntions of pep8 have been replaced with pycodestyle
+
+## Add script to replace outdated settings with the new ones in user settings.json
+
+* python.linting.pep8Args -> python.linting.pycodestyleArgs
+* python.linting.pep8CategorySeverity.E -> python.linting.pycodestyleCategorySeverity.E
+* python.linting.pep8CategorySeverity.W -> python.linting.pycodestyleCategorySeverity.W
+* python.linting.pep8Enabled -> python.linting.pycodestyleEnabled
+* python.linting.pep8Path -> python.linting.pycodestylePath

package.json

@@ -1754,56 +1754,7 @@
                     "description": "Path to mypy, you can use a custom version of mypy by modifying this setting to include the full path.",
                     "scope": "resource"
                 },
-                "python.linting.pep8Args": {
-                    "type": "array",
-                    "description": "Arguments passed in. Each argument is a separate item in the array.",
-                    "default": [],
-                    "items": {
-                        "type": "string"
-                    },
-                    "scope": "resource",
-                    "deprecationMessage": "pep8 has been renamed to pycodestyle. This settng is replaced by python.formating.pycodestyleArgs"
-                },
-                "python.linting.pep8CategorySeverity.E": {
-                    "type": "string",
-                    "default": "Error",
-                    "description": "Severity of Pep8 message type 'E'.",
-                    "enum": [
-                        "Hint",
-                        "Error",
-                        "Information",
-                        "Warning"
-                    ],
-                    "scope": "resource",
-                    "deprecationMessage": "pep8 has been renamed to pycodestyle. This settng is replaced by python.formating.pycodestyleSeverity.E"
-                },
-                "python.linting.pep8CategorySeverity.W": {
-                    "type": "string",
-                    "default": "Warning",
-                    "description": "Severity of Pep8 message type 'W'.",
-                    "enum": [
-                        "Hint",
-                        "Error",
-                        "Information",
-                        "Warning"
-                    ],
-                    "scope": "resource",
-                    "deprecationMessage": "pep8 has been renamed to pycodestyle. This settng is replaced by python.formating.pycodestyleSeverity.W"
-                },
-                "python.linting.pep8Enabled": {
-                    "type": "boolean",
-                    "default": false,
-                    "description": "Whether to lint Python files using pep8",
-                    "scope": "resource",
-                    "deprecationMessage": "pep8 has been renamed to pycodestyle. This settng is replaced by python.formating.pycodestyleEnabled"
-                },
-                "python.linting.pep8Path": {
-                    "type": "string",
-                    "default": "pep8",
-                    "description": "Path to pep8, you can use a custom version of pep8 by modifying this setting to include the full path.",
-                    "scope": "resource",
-                    "deprecationMessage": "pep8 has been renamed to pycodestyle. This settng is replaced by python.formating.pycodestylePath"
-                },
+
                 "python.linting.pycodestyleArgs": {
                     "type": "array",
                     "description": "Arguments passed in. Each argument is a separate item in the array.",

src/client/testing/common/updateTestSettings.ts

@@ -53,17 +53,25 @@ export class UpdateTestSettingService implements IExtensionActivationService {
         const setting_pytest_enabled = new RegExp('.pyTestEnabled"', 'g');
         const setting_pytest_args = new RegExp('.pyTestArgs"', 'g');
         const setting_pytest_path = new RegExp('.pyTestPath"', 'g');
+        const setting_pep8_args = new RegExp('.(?<!auto)pep8Args', 'g');
+        const setting_pep8_cat_severity = new RegExp('.pep8CategorySeverity\.', 'g');
+        const setting_pep8_enabled = new RegExp('.pep8Enabled', 'g');
+        const setting_pep8_path = new RegExp('.(?<!auto)pep8Path', 'g');
 
         fileContents = fileContents.replace(setting, '"python.testing');
         fileContents = fileContents.replace(setting_pytest_enabled, '.pytestEnabled"');
         fileContents = fileContents.replace(setting_pytest_args, '.pytestArgs"');
         fileContents = fileContents.replace(setting_pytest_path, '.pytestPath"');
+        fileContents = fileContents.replace(setting_pep8_args, '.pycodestyleArgs');
+        fileContents = fileContents.replace(setting_pep8_cat_severity, '.pycodestyleCategorySeverity.');
+        fileContents = fileContents.replace(setting_pep8_enabled, '.pycodestyleEnabled');
+        fileContents = fileContents.replace(setting_pep8_path, '.pycodestylePath');
         await this.fs.writeFile(filePath, fileContents);
     }
     public async doesFileNeedToBeFixed(filePath: string) {
         try {
             const contents = await this.fs.readFile(filePath);
-            return contents.indexOf('python.unitTest.') > 0 || contents.indexOf('.pyTest') > 0;
+            return contents.indexOf('python.unitTest.') > 0 || contents.indexOf('.pyTest') > 0 || contents.indexOf('.pep8') > 0;
         } catch (ex) {
             traceError('Failed to check if file needs to be fixed', ex);
             return false;