Skip to content

Conversation

@karrtikr
Copy link

@karrtikr karrtikr commented Sep 1, 2020

For #13716 Fixes #13312

Note isort5 has a bug which does not allow users to use deprecated arguments in python.sortImports.args, when using stdin like we do: PyCQA/isort#1447. It throws errors instead of printing the warning related to deprecation.

I have identified the fix in isort5 and suggested it to them. After they release the fix, we'll need to upgrade isort again. In this PR I'm assuming isort5 has fixed the bug and we're getting errors with warning codes when user uses deprecated settings.

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2020

Codecov Report

Merging #13717 into master will decrease coverage by 0.00%.
The diff coverage is 86.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13717      +/-   ##
==========================================
- Coverage   59.82%   59.82%   -0.01%     
==========================================
  Files         675      675              
  Lines       37798    37820      +22     
  Branches     5445     5452       +7     
==========================================
+ Hits        22612    22624      +12     
+ Misses      14028    14019       -9     
- Partials     1158     1177      +19     
Impacted Files Coverage Δ
src/client/providers/importSortProvider.ts 83.84% <85.71%> (+1.11%) ⬆️
src/client/common/utils/localize.ts 96.22% <100.00%> (+<0.01%) ⬆️
src/client/datascience/crossProcessLock.ts 79.41% <0.00%> (-11.77%) ⬇️
src/client/common/utils/platform.ts 56.00% <0.00%> (-4.00%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️
src/client/common/configSettings.ts 69.28% <0.00%> (-0.38%) ⬇️
src/client/common/types.ts 100.00% <0.00%> (ø)
src/client/logging/levels.ts 61.11% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 869ec10...3b11066. Read the comment docs.

…s attempt to run isort5 using deprecated settings
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 2, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.9% 0.9% Duplication

@karrtikr karrtikr merged commit 6489528 into microsoft:master Sep 2, 2020
@karrtikr karrtikr deleted the isortporpmt branch September 2, 2020 15:38
@karrtikr karrtikr mentioned this pull request Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants