Skip to content

Conversation

@brettcannon
Copy link
Member

Fixes #1374

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)
  • Has unit tests & code coverage is not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

@codecov
Copy link

codecov bot commented Apr 12, 2018

Codecov Report

Merging #1375 into master will decrease coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1375      +/-   ##
==========================================
- Coverage   71.45%   71.08%   -0.37%     
==========================================
  Files         269      269              
  Lines       12403    12403              
  Branches     2199     2199              
==========================================
- Hits         8862     8817      -45     
- Misses       3411     3450      +39     
- Partials      130      136       +6
Impacted Files Coverage Δ
src/client/linters/errorHandlers/notInstalled.ts 33.33% <0%> (-61.12%) ⬇️
src/client/linters/errorHandlers/errorHandler.ts 77.77% <0%> (-22.23%) ⬇️
src/client/common/logger.ts 53.33% <0%> (-20.01%) ⬇️
src/client/common/application/applicationShell.ts 23.07% <0%> (-7.7%) ⬇️
src/client/debugger/PythonProcess.ts 45.83% <0%> (-5.42%) ⬇️
src/client/common/installer/productInstaller.ts 60.31% <0%> (-4.24%) ⬇️
src/client/linters/baseLinter.ts 87.5% <0%> (-4.17%) ⬇️
...reter/locators/services/cacheableLocatorService.ts 91.83% <0%> (-4.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2027fce...0c8cf74. Read the comment docs.

@brettcannon brettcannon merged commit 7cd5095 into microsoft:master Apr 12, 2018
@brettcannon brettcannon deleted the pinned-deps branch April 12, 2018 21:41
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use yarn install --frozen-lockfile for CI

2 participants