Expose a setting to allow a user modify the working directory of linters

[matthewshirley]

Closes #15170

• Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
• Title summarizes what is changing.
• Appropriate comments and documentation strings in the code.
• Has sufficient logging.
• Has telemetry for enhancements.
• The wiki is updated with any design decisions/details.

Labels

Needs skip package*.json

Tests

I'm uncertain where to introduce tests for this PR. I couldn't identify where it would fit. Let me know if they're need and the best suite for them. 💪

[karrtikr]

This may need to change after #15266 is merged.

[kimadeline]

Hi @matthewshirley, thank you for your contribution!

Yep please add tests, src/test/linters/lint.functional.test.ts would be a good spot for them. Adding them to the existing suite should be fine.

I left a couple of comments regarding the type of the python.linting.cwd setting, they apply to src/test/linters/common.ts and src/test/mockClasses.ts as well.

[bl-ue]

Any progress? Dying for this feature.

[karrtikr]

@bl-ue Waiting on @matthewshirley to address the comments.

[matthewshirley]

I will respond and work on tests for the PR this week. 👍 Thanks for the patience.

[karrtikr]

Please have a look at

vscode-python/src/client/linters/baseLinter.ts

Line 98 in e3e773a

protected getWorkspaceRootPath(document: vscode.TextDocument): string {

Attempt to find all references to the method.

It looks like we assume that is the cwd in these places. For eg.

vscode-python/src/client/linters/prospector.ts

Line 33 in db8e1e2

const cwd = this.getWorkspaceRootPath(document);

I think you'll need to adjust that method to return the correct cwd using the setting instead of the workspace root, and use the workspace root as default cwd if not set.

[karrtikr]

LGTM, thanks!

[kimadeline]

Thank you again for your contribution, @matthewshirley! 🥳

[bl-ue]

🚀 🎊 🎉

[lg-kialo]

Thank you so much for this!