Bundle Pylance as part of an extension pack (not a hard dependency) #16077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimadeline
added
no-changelog
kimadeline
changed the title
karrtikr
approved these changes
Apr 29, 2021
karrtikr
left a comment
karrtikr
left a comment
There was a problem hiding this comment.
LGTM. Do we need to add a news entry?
Author
|
I don't think so, not yet at least. I was going to add a news entry when we update the readme (which should be soon enough). |
jakebailey
reviewed
Apr 29, 2021
| - run: npm run addExtensionDependencies | ||
| shell: bash | ||
|
|
||
| - run: npm run addExtensionPackDependencies |
Member
There was a problem hiding this comment.
Any reason to use another gulp task rather than just having it be a part of the extension dependencies one?
Author
There was a problem hiding this comment.
I figured we might want to keep them separate since it's messing with a different package.json key.
karthiknadig
approved these changes
May 3, 2021
kimadeline
added a commit
that referenced
this pull request
May 5, 2021
* Bundle Pylance as part of an extension pack (not a hard dependency) (#16077) * extension pack * Undo package.json change * Add extension pack link at build time * Forgot to update all names * Update readme + license at build time (#16134) * Add license update * Update package.json description * Update readme * Add news file * Update header wording * let -> const * Wording * Consistenly use VS Code long form * Display an informational Pylance prompt for existing users (#16069) * Export extension version memento * Add localization strings * Add prompt check * Add to the list of things triggering on activation * Add tests * Rename file * Remove unsupported newlines * Fix localization + re-add newlines * Change to be a non-blocking diagnostic check * Change localization key * Update memento on close instead of just on ok * Fix localization * Add initialMementoValue handler * Links * Fix tests * Fix tests * Set PYLANCE_PROMPT_MEMENTO to false * Remove unused line * Set to true directly * Remove extra updateMemento calls * I can't read * Period * Run in foreground * Add handling test * Remove extension pack category (#16149) Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For https://github.com/microsoft/vscode-python-internalbacklog/issues/180
Bundling Pylance as an extension pack (not a hard dependency) at build time. Also, I am bad at naming things, please suggest different names if you can think of something more fitting.