Skip to content

Conversation

@karrtikr
Copy link

@karrtikr karrtikr commented May 4, 2021

For https://github.com/microsoft/vscode-python-internalbacklog/issues/196

See https://github.com/microsoft/vscode-python/actions/runs/811168374, The artifact uploaded is named $ {{ steps.vsix_names.outputs.vsix_artifact_name }} instead of ms-python-insiders-vsix. That is probably because of the space character after $.

I expect this to fix the smoke tests.

@karrtikr karrtikr added no-changelog No news entry required skip tests Updates to tests unnecessary labels May 4, 2021
@karrtikr karrtikr changed the title [DO NOT REVIEW] Fix smoke tests part 2 Correct the vsix artifact name to be uploaded May 4, 2021
@karrtikr karrtikr marked this pull request as ready for review May 4, 2021 22:17
@karrtikr karrtikr requested a review from brettcannon May 4, 2021 22:18
@karrtikr karrtikr merged commit 908684b into microsoft:main May 4, 2021
@karrtikr karrtikr deleted the smokeBuild branch May 4, 2021 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog No news entry required skip tests Updates to tests unnecessary

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants