Make Jupyter an optional dependency #16267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimadeline
added
the
skip package*.json
| const packageJsonContents = await fsExtra.readFile('package.json', 'utf-8'); | ||
| const packageJson = JSON.parse(packageJsonContents); | ||
| packageJson.extensionPack = ['ms-python.vscode-pylance'].concat( | ||
| packageJson.extensionPack = ['ms-toolsai.jupyter', 'ms-python.vscode-pylance'].concat( |
There was a problem hiding this comment.
why not hardcode this in package.json instead of injecting this during build time?
There was a problem hiding this comment.
+1. That should work. Since these are optional dependencies they should not affect debugging like required dependencies did.
There was a problem hiding this comment.
Are we ok with hardcoding them now? There were some concerns about hardcoding Pylance when we added it.
There was a problem hiding this comment.
Discussed with @brettcannon, not going to hardcode this, as we would prefer keeping the package.json dependency-free, and add them at build time instead.
| const packageJson = JSON.parse(packageJsonContents); | ||
| packageJson.extensionPack = ['ms-python.vscode-pylance'].concat( | ||
| packageJson.extensionPack = ['ms-toolsai.jupyter', 'ms-python.vscode-pylance'].concat( | ||
| packageJson.extensionPack ? packageJson.extensionPack : [], |
There was a problem hiding this comment.
Suggested change
| packageJson.extensionPack ? packageJson.extensionPack : [], | |
| packageJson.extensionPack || [], |
There was a problem hiding this comment.
If we follow the previous comment this won't be needed.
karthiknadig
approved these changes
May 18, 2021
rchiodo
approved these changes
May 18, 2021
karrtikr
approved these changes
May 18, 2021
Co-authored-by: Kartik Raj <karraj@microsoft.com>
This was referenced May 26, 2021
karrtikr
pushed a commit
that referenced
this pull request
Jun 8, 2021
* Make Jupyter an optional dependency (#16267) * News entry * Move Jupyter to the optional dependencies step * Update news/1 Enhancements/16102.md Co-authored-by: Kartik Raj <karraj@microsoft.com> Co-authored-by: Kartik Raj <karraj@microsoft.com> * License wording update (#16278) * Wording * License wording * Add a "Jupyter not installed" notification helper (#16321) * Add telemetry info * Use enum for the telemetry * Add prompt as a standalone function * Remove "Install" from the prompt * Make it a class * Register singleton * Rename file to a long but descriptive name * Unit tests * Add to package.nls.json * Use sinon for tests * Use the same "Jupyter is not installed" message everywhere (#16372) * rename to showJupyterNotInstalledPrompt * Replace existing prompt with new prompt * Remove Jupyter check from command manager * Update the start page to use the prompt (#16417) * Update copy * Update origin key * Show prompt if jupyter not installed & should show * Add tests for this functionality only * Update news entry * Remove comments * follow-up from the merge * Add singletons for startpage functional tests * Missing one symbol * Update src/client/common/startPage/startPage.ts Co-authored-by: Don Jayamanne <don.jayamanne@outlook.com> * Add logging Co-authored-by: Don Jayamanne <don.jayamanne@outlook.com> Co-authored-by: Kartik Raj <karraj@microsoft.com> Co-authored-by: Don Jayamanne <don.jayamanne@outlook.com>
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #16102