Skip to content

Add Pytest Code But Keep Inactive for Pytest Discovery #20210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 35 commits into from
Closed

Add Pytest Code But Keep Inactive for Pytest Discovery #20210

wants to merge 35 commits into from
+204 −22

Conversation

eleanorjboyd
Copy link
Member

@eleanorjboyd eleanorjboyd commented Nov 10, 2022 •
edited by karrtikr
Loading

Fixes #20079

@eleanorjboyd eleanorjboyd self-assigned this Nov 10, 2022
@eleanorjboyd eleanorjboyd added the no-changelog No news entry required label Nov 10, 2022
karthiknadig
karthiknadig reviewed Nov 10, 2022
View reviewed changes
karthiknadig
karthiknadig requested changes Nov 10, 2022
View reviewed changes
@eleanorjboyd eleanorjboyd marked this pull request as ready for review November 11, 2022 19:42
@vscodenpa vscodenpa added this to the November 2022 milestone Nov 11, 2022
karrtikr
karrtikr reviewed Dec 19, 2022
View reviewed changes
karthiknadig
karthiknadig reviewed Jan 23, 2023
View reviewed changes
@eleanorjboyd eleanorjboyd mentioned this pull request Jan 25, 2023
Merged
karrtikr
karrtikr previously approved these changes Jan 31, 2023
View reviewed changes
Copy link

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise.

@eleanorjboyd eleanorjboyd requested a review from karrtikr January 31, 2023 16:38
karrtikr
karrtikr reviewed Jan 31, 2023
View reviewed changes
@eleanorjboyd eleanorjboyd requested a review from karrtikr January 31, 2023 17:45
karrtikr
karrtikr reviewed Jan 31, 2023
View reviewed changes
Copy link

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see other console.* calls as well.

@eleanorjboyd
Copy link
Member Author

closing in favor of #20566

@eleanorjboyd eleanorjboyd deleted the pytest_discovery_inactive_addition branch January 31, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karthiknadig karthiknadig Awaiting requested review from karthiknadig

1 more reviewer

@karrtikr karrtikr karrtikr left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@eleanorjboyd eleanorjboyd

Labels

no-changelog No news entry required skip tests Updates to tests unnecessary

Projects

None yet

Milestone

February 2023

Development

Successfully merging this pull request may close these issues.

Connect Pytest Discovery Plugin to Testing UI

5 participants

@eleanorjboyd @karthiknadig @karrtikr @brettcannon @vscodenpa