Variable Explorer UI cleanup #5379
Conversation
|
Cleaned up -> Double click a row to open data explorer |
| let newTitle = `${localize.DataScience.dataExplorerTitle()} - ${variable.name}`; | ||
| const TRIM_LENGTH = 40; | ||
| if (newTitle.length > TRIM_LENGTH) { | ||
| newTitle = `${newTitle.substr(0, TRIM_LENGTH)}...`; |
There was a problem hiding this comment.
I would have expected such truncation to take place in CSS based on relative widths (e.g. %s of the total width, along with min width.. or similar)
There was a problem hiding this comment.
@DonJayamanne Hmmm, do you know of how we could actually see the widths? This is the string that goes in the VSCode editor file tab. We don't own the UI for that in our extension. When testing I realized that it doesn't truncate in the vscode editor tab (at least I was able to make a tab that took up basically my entire editor tab space) so this was just a sanity check to avoid a degenerate case with a super long variable name.
There was a problem hiding this comment.
Oh, if its for VSC, then its fine. I thought this was for the react webview.
* variable explorer UI feedback fixes * add new entry * review feedback
3 participants
For #5274
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)