notebooks: ensure preloads load before webview output is shown #101166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This serializes code in the webview so that we make sure preloads load before rending output. Since the rendering of HTML can be deferred, we also potentially need to defer other actions like clearing and focusing.
masato1015
approved these changes
Jun 27, 2020
connor4312
commented
Jun 29, 2020
| type: 'clear'; | ||
| } | ||
|
|
||
| export interface IFocusOutputMessage { |
Member
Author
There was a problem hiding this comment.
(this was duplicated, likely a copy-paste error)
connor4312
commented
Jun 29, 2020
| } | ||
|
|
||
| createInset(cell: CodeCellViewModel, output: IProcessedOutput, cellTop: number, offset: number, shadowContent: string, preloads: Set<string>) { | ||
| async createInset(cell: CodeCellViewModel, output: IProcessedOutput, cellTop: number, offset: number, shadowContent: string, preloads: Set<string>) { |
Member
Author
There was a problem hiding this comment.
I think making this async is safe, since the display of content was already asynchronous behind the postMessage being sent.
Member
There was a problem hiding this comment.
It's safe. Can we also make the call hierarchy explicit async then others won't use it incorrectly later on?
rebornix
approved these changes
Jun 29, 2020
Member
rebornix
left a comment
rebornix
left a comment
There was a problem hiding this comment.
LGTM. Tested with setTimeout and it works fine.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This serializes code in the webview so that we make sure preloads load
before rending output. Since the rendering of HTML can be deferred,
we also potentially need to defer other actions like clearing and
focusing.
This PR fixes #101151
/cc @JacksonKearl