Default formatter results strange indents for TypeScript code.

[seiyab]

TS Template added by @mjbvz

TypeScript Version: 4.0.0-dev.20200720

Search Terms

• format, formatter, formatting
• indent

---

Abstract

When I open object literal brace after comma in function arguments and break line immediately, format results strange indent.

Example

Code I wrote is like below. And I think following indents is one of desired formats.

f(
  foo, {
    bar: 'qux',
  },
);

When I save

f(
  foo, {
  bar: 'qux',
},
);

Desired

f(
  foo, {
    bar: 'qux',
  },
);

or

f(
  foo,
  {
    bar: 'qux',
  },
);

Issue Template

• VSCode Version: 1.45.1, 1.48.0-insider
• OS Version: macOS Catalina 10.15.5

Steps to Reproduce:

1. enable formatOnSave.
2. write a TypeScript file like bellow

// reproduce.ts
console.log(
  1, {
    a: 1,
  },
)

3. save

Does this issue occur when all extensions are disabled?: Yes

[damienhoneyford]

I think I've just hit this bug whilst transpiling to ES5, see the Playground example

Example TypeScript:

const commaSeparatedString = "1,2,3,4,5,6";

const intArray = commaSeparatedString
    .split(',')
    .map(s => {
        if (s !== '')
            return parseInt(s);
        else
            return undefined;
    })
    .filter(i => typeof i === 'number' && !isNaN(i));

Transpiled Output:

"use strict";
var commaSeparatedString = "1,2,3,4,5,6";
var intArray = commaSeparatedString
    .split(',')
    .map(function (s) {
    if (s !== '')
        return parseInt(s);
    else
        return undefined;
})
    .filter(function (i) { return typeof i === 'number' && !isNaN(i); });

Expected Output:

"use strict";
var commaSeparatedString = "1,2,3,4,5,6";
var intArray = commaSeparatedString
    .split(',')
    .map(function (s) {
        if (s !== '')
            return parseInt(s);
        else
            return undefined;
    })
    .filter(function (i) { return typeof i === 'number' && !isNaN(i); });

[RyanCavanaugh]

Closing language service bugs related to the 6.0 implementation. For more information, see #62827