Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only add menu contribution when having call hierarchy provider #104977

Merged
merged 1 commit into from Aug 19, 2020

Conversation

jrieken
Copy link
Member

@jrieken jrieken commented Aug 19, 2020

This PR is part of #104727

@jrieken jrieken self-assigned this Aug 19, 2020
@jrieken jrieken requested a review from dbaeumer August 19, 2020 08:16
@jrieken
Copy link
Member Author

jrieken commented Aug 19, 2020

This PR repeats the precondition (which controls enablement) for the menu contribution so that "Peek Call Hierarchy" won't show (instead of showing as disabled). With that the Peek-submenu becomes empty and, in return, won't show anymore

@jrieken jrieken merged commit 92cfbd3 into release/1.48 Aug 19, 2020
@jrieken jrieken deleted the joh/fix104727 branch August 19, 2020 12:51
@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants