[typescript] removing a bracket loses all folded areas

[waitwhatActo]

TS Template added by @mjbvz

TypeScript Version: 4.1.0-dev.20201002

Search Terms

• folding / folds
• getOutlineSpans

(see my comment for a self contained example)

---

• VSCode Version: 1.47.0
• OS Version: Windows 10 Verison 1909

Steps to Reproduce:

1. make an error on the code with all lines collapsed.
2. It will automatically expand all the codes. Which is annoying. Bcuz I have to collapse it automatically.

Does this issue occur when all extensions are disabled?: Yes

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• Compact explorer tree nodes don't narrate "Expanded" and "Collapsed" (#86414)
• Test: Notebook cell collapse (#103887)
• large format change losses folding ranges (#86621)
• Allow right arrow on a collapsed cell to expanded (#104116)

[aeschli]

Can you add more detailed steps and and a specific code example? We only expand folded regions if the cursor has been placed in a folded regions or of a code change causes the regions to go away (e.g. by opening a string or comment)

[waitwhatActo]

It's actually the code. If I am typing something that the program changes the colour of the code below, the collapsed code will be expanded automatically. Which is annoying.

[aeschli]

Do you have a small code sample so I can investigate?

[waitwhatActo]

I can send you a video if you want

[waitwhatActo]

but where do I drop it?

[aeschli]

You can attach files to the issue with drag & drop

[waitwhatActo]

Doesn't support videos.
I will zip the file.

[waitwhatActo]

VSCode Problem.zip
Here^
Extract it

[aeschli]

The zip file seems to be invalid...

[waitwhatActo]

https://youtu.be/Vo6x6i-iIhE try this

[aeschli]

Thanks that worked, thanks for the video.
The problem is that by deleting a closing bracket, the TypeScript parser can not properly parse the content and can no longer find the same blocks as before.
So the folding regions are not reported and we have to unfold them.

It's a difficult problem which, IMO, must be solved with error recovery in the TS parser.