workspace folders map should ignore path casing unless linux

[jrieken]

This PR fixes #110188

[sandy081]

LGTM

Note: Did not verify the fix.

[isidorn]

While this improves the situation with the workspace check. The Explorer still does not reveal. I am investigating further...

[isidorn]

Ok, an issue remains, and that is that the fileService.resolveTo does not properly resolve when I pass in the wrongly cased drive letter.
@bpasero might you have an idea if the fileService also uses TernarySearchTree?

Code pointer where I use it
Since I pass in the wrong cased drive letter the resolveTo does not seem to be respected.

To repro on Win

1. Put a breakpoint in my code pointer
2. Open some workspace. Drag from Windows Explorer a file deep inside that workspace -> it does not get revealed

[isidorn]

Ok here it is

vscode/src/vs/platform/files/common/fileService.ts

Line 196 in 59a1893

trie = TernarySearchTree.forUris<true>();

Checking if changing it there also helps...

[isidorn]

Yeah, that would also have to be changed. I have verified with that change that the issue is fixed.

[bpasero]

This code is actually literally copied from how @jrieken had it before I rewrote file service. I think it should use the file system provider's capability for the ternary tree there as well.

[isidorn]

@bpasero yeah I just pushed that. Please review and let me know what you think.
If you think it is good I will also push to master.

[bpasero]

Left a comment. Created #110241 for the actual solution.

[bpasero]

use isPathCaseSensitive in that file

[jrieken]

Hm... Should we simply bring back the old behaviour instead of picking on a few places?

[isidorn]

@jrieken yeah that might be best.

[jrieken]

closing and creating another PR which basically undoes my initial refactoring