Mitigate #109728 #112008
Merged
Mitigate #109728 #112008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaomoreno
added
the
candidate
bpasero
approved these changes
Dec 7, 2020
Member
bpasero
left a comment
bpasero
left a comment
There was a problem hiding this comment.
Some notes:
- previously the command would return the result of
quitAndInstallfrom the command, not sure that was needed - searching for references to
IUpdateService.quitAndInstallthere seems to be more than this location but I am not sure if they need this change too
Contributor
|
New flow works fine. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mitigation for #109728