Skip to content

Fix: debug.console.wordWrap dont need restart #114677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
susiwen8 wants to merge 3 commits into from
Closed

Fix: debug.console.wordWrap dont need restart #114677

susiwen8 wants to merge 3 commits into from

Conversation

@susiwen8
Copy link
Contributor

@susiwen8 susiwen8 commented Jan 21, 2021

This PR fixes #76095

Change debug.console.wordWrap trigger onDidStyleChange

@isidorn isidorn assigned isidorn and unassigned weinand Jan 22, 2021
@isidorn isidorn added the debug Debug viewlet, configurations, breakpoints, adapter issues label Jan 22, 2021
@isidorn
Copy link
Collaborator

isidorn commented Jan 22, 2021

Thanks for this PR, however unfortunetly this does not fix the issue.
The tree does not allow to dynamicaly update the dynamicHeight option. The only way to fix this is to re-create the tree. And that I think is completely a different approach, thus closing this PR.
If you tested this, made sure it works, let me know and I can reopen

@isidorn isidorn closed this Jan 22, 2021
@susiwen8 susiwen8 deleted the console-wordwrap branch January 22, 2021 14:17
@github-actions github-actions bot locked and limited conversation to collaborators Mar 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@isidorn isidorn

Labels

debug Debug viewlet, configurations, breakpoints, adapter issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Changing debug.console.wordWrap needs a restart

3 participants

@susiwen8 @isidorn @weinand