Skip to content

Render unbound keybindings #120057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jeanp413 wants to merge 1 commit into from
Closed

Render unbound keybindings #120057

jeanp413 wants to merge 1 commit into from

Conversation

@jeanp413
Copy link
Contributor

@jeanp413 jeanp413 commented Mar 28, 2021

This PR fixes #119712

@sandy081
Copy link
Member

sandy081 commented Mar 30, 2021

@jeanp413 I am sorry that I added help wanted label for #119712. After thinking a bit it does not feel like to me if it is worth to implement this. Hence I removed the labels and closed the issue as out of scope. So closing this PR too.

@sandy081 sandy081 closed this Mar 30, 2021
@jeanp413 jeanp413 deleted the unbound-keybinding branch March 30, 2021 16:00
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@sandy081 sandy081

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Nit: empty keybindings editor should render something more

2 participants

@jeanp413 @sandy081