Skip to content

Workaround for terminal editor bug related to detaching from the element #127889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
meganrogge merged 1 commit into from
Jul 2, 2021
Merged

Workaround for terminal editor bug related to detaching from the element #127889

meganrogge merged 1 commit into from
Jul 2, 2021

Conversation

@meganrogge
Copy link
Contributor

@meganrogge meganrogge commented Jul 2, 2021 •
edited
Loading

This PR fixes #126469

See #126469 (comment)

@meganrogge meganrogge self-assigned this Jul 2, 2021
@meganrogge meganrogge added this to the June 2021 milestone Jul 2, 2021
@meganrogge meganrogge requested a review from Tyriar July 2, 2021 16:15
@meganrogge meganrogge linked an issue Jul 2, 2021 that may be closed by this pull request
Creating a terminal editor in a new group detaches the other terminal editor #126469
Closed
@meganrogge meganrogge added the candidate Issue identified as probable candidate for fixing in the next release label Jul 2, 2021
@rzhao271 rzhao271 self-requested a review July 2, 2021 17:11
rzhao271
rzhao271 approved these changes Jul 2, 2021
View reviewed changes
Copy link
Collaborator

@rzhao271 rzhao271 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Checked out branch and tested on OSS.
Note this change causes every new terminal editor to open in a side group automatically, rather than in the same editor group.

@meganrogge meganrogge merged commit 99653c6 into release/1.58 Jul 2, 2021
@meganrogge meganrogge deleted the merogge/terminal-editor branch July 2, 2021 19:21
meganrogge added a commit that referenced this pull request Jul 2, 2021
@meganrogge
fix #126469 (#127889)
aa77448
@github-actions github-actions bot locked and limited conversation to collaborators Aug 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@rzhao271 rzhao271 rzhao271 approved these changes

@Tyriar Tyriar Awaiting requested review from Tyriar

Assignees

@meganrogge meganrogge

Labels

candidate Issue identified as probable candidate for fixing in the next release

Projects

None yet

Milestone

June 2021

Development

Successfully merging this pull request may close these issues.

Creating a terminal editor in a new group detaches the other terminal editor

3 participants

@meganrogge @rzhao271