Adopts injected text for inlay text. #128646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for injected text. Adopts injected text for inlay text.
hediet
force-pushed
the
hediet/inlay-hints-injected-text
branch
from
0eeb7dd to
f1b3605
Compare
jrieken
approved these changes
Jul 14, 2021
Member
jrieken
left a comment
jrieken
left a comment
There was a problem hiding this comment.
Some nit, overall I like how little editor API changes this is
Contributor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI @jrieken @mjbvz @Kingwl
At some point,
beforeInjectedText/afterInjectedTextshould replacebefore/after.However, that is a breaking change, as you can insert css decorations (e.g. symbols) with
before(without any text), but this is not possible with injected text. By design, injected text has no effect if the injected text is empty.Use
editor.useInjectedText: falseto go back to before/after css decorations.