Allow calling updateElementHeight with undefined to prompt re-probing of dynamic height #129181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
The settings editor part LGTM. |
rzhao271
approved these changes
Jul 22, 2021
Member
Author
|
Could you take a look at this next month @joaomoreno? |
joaomoreno
approved these changes
Aug 31, 2021
| if (this.items[index].size === size) { | ||
| const originalSize = this.items[index].size; | ||
|
|
||
| if (typeof size === 'undefined') { |
Member
There was a problem hiding this comment.
Should we console.warn if !this.supportDynamicHeights?
… of dynamic height See #128563
roblourens
force-pushed
the
roblou/updateElementHeight
branch
from
b88e9f5 to
24e8396
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #128563