Cancel edit when leaving widget #129276
Closed
Cancel edit when leaving widget #129276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roblourens
approved these changes
Jul 23, 2021
Member
There was a problem hiding this comment.
So this happens if you edit in the setting, then do something so the setting gets re-rendered, and it steals focus?
The downside is that the widgets now leave edit mode more eagerly, which might result in more clicks as users go back and forth to edit settings.
I think an alternative would be do to this cancelEdit when disposeElement is called? Up to you
Collaborator
Author
|
That sounds cleaner; I'll try with |
Collaborator
Author
|
I'll move this PR out to the next milestone. It's cleaner when using
|
Collaborator
Author
|
Closing in favour of #129458 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #125166
This PR adds a few blur handlers to the list, exclude, and object dropdown widgets, so that when the user goes back to the searchbox and types, focus doesn't accidentally go back to the widget.
The downside is that the widgets now leave edit mode more eagerly, which might result in more clicks as users go back and forth to edit settings.