Skip to content

Conversation

@lramos15
Copy link
Member

@lramos15 lramos15 commented Aug 4, 2021

This PR fixes #129053

Adds an embedder identifier to the vscode.env namespace so that extensions know the shell hosting vs code.

@lramos15 lramos15 requested a review from mjbvz August 4, 2021 13:48
@lramos15 lramos15 self-assigned this Aug 4, 2021

export namespace env {
/**
* The environment in which the app is embedded in. i.e. Desktop, Codespaces, Web.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other changes in this commit suggest that the string values aren't capitalised.

Copy link
Member Author

@lramos15 lramos15 Aug 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you that is correct they are lowercase, I've pushed 5b9f4ad

Copy link
Collaborator

@mjbvz mjbvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lramos15 lramos15 merged commit d18e54f into main Aug 5, 2021
@lramos15 lramos15 deleted the lramos15/embedderIdentifier branch August 5, 2021 13:58
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expand vscode.env to include Product

4 participants