Update ownership of workspace parent folder

[Timmmm]

• VS Code Version: master as of right now (7c25c174726ab969db3f99058cdf24bcfae1cfbe).
• OS Version: MacOS

Steps to Reproduce:

1. Clone the VSCode repo.
2. Install Docker.
3. Open the workspace in the dev container.
4. yarn
5. yarn run gulp vscode-linux-x64

Gives the following output:

node ➜ /workspaces/vscode_linux (main) $ yarn run gulp vscode-linux-x64
yarn run v1.22.5
$ node --max_old_space_size=8192 ./node_modules/gulp/bin/gulp.js vscode-linux-x64
[08:33:38] Using gulpfile /workspaces/vscode_linux/gulpfile.js
[08:33:38] Starting 'vscode-linux-x64'...
[08:33:38] Starting clean-out-build ...
[08:33:38] Finished clean-out-build after 5 ms
[08:33:38] Starting compile-build ...
[08:33:43] Starting compilation...
[08:37:35] Finished compilation with 0 errors after 232123 ms
[08:37:36] Finished compile-build after 237981 ms
[08:37:36] Starting clean-extensions-build ...
[08:37:36] Finished clean-extensions-build after 9 ms
[08:37:36] Starting bundle-extensions-build ...
[08:39:25] Bundled extension: search-result/extension.webpack.config.js...
[08:39:28] Bundled extension: image-preview/extension.webpack.config.js...
[08:39:29] Bundled extension: gulp/extension.webpack.config.js...
[08:39:29] Bundled extension: jake/extension.webpack.config.js...
[08:39:29] Bundled extension: grunt/extension.webpack.config.js...
[08:39:29] Bundled extension: simple-browser/extension.webpack.config.js...
[08:39:29] Bundled extension: debug-server-ready/extension.webpack.config.js...
[08:39:29] Bundled extension: debug-auto-launch/extension.webpack.config.js...
[08:39:33] Bundled extension: markdown-math/extension.webpack.config.js...
[08:39:33] Bundled extension: configuration-editing/extension.webpack.config.js...
[08:39:42] Bundled extension: merge-conflict/extension.webpack.config.js...
[08:39:45] Bundled extension: ipynb/extension.webpack.config.js...
[08:39:46] Bundled extension: php-language-features/extension.webpack.config.js...
[08:39:49] Bundled extension: microsoft-authentication/extension.webpack.config.js...
[08:39:59] Bundled extension: extension-editing/extension.webpack.config.js...
[08:40:09] Bundled extension: emmet/extension.webpack.config.js...
[08:40:13] Bundled extension: typescript-language-features/extension.webpack.config.js...
[08:40:18] Bundled extension: markdown-language-features/extension.webpack.config.js...
[08:40:24] Bundled extension: json-language-features/server/extension.webpack.config.js...
[08:40:24] Bundled extension: css-language-features/extension.webpack.config.js...
[08:40:28] Bundled extension: npm/extension.webpack.config.js...
[08:40:29] Bundled extension: git/extension.webpack.config.js...
[08:40:29] Bundled extension: json-language-features/extension.webpack.config.js...
[08:40:33] Bundled extension: css-language-features/server/extension.webpack.config.js...
[08:40:35] Bundled extension: html-language-features/server/extension.webpack.config.js...
[08:40:36] Bundled extension: github/extension.webpack.config.js...
[08:40:36] Bundled extension: html-language-features/extension.webpack.config.js...
[08:40:47] Bundled extension: github-authentication/extension.webpack.config.js...
[08:40:47] Finished bundle-extensions-build after 190993 ms
[08:40:47] Starting bundle-marketplace-extensions-build ...
[08:40:49] Downloading extension: ms-vscode.references-view@0.0.80 ...
[08:40:49] Downloading extension: ms-vscode.js-debug-companion@1.0.14 ...
[08:40:49] Downloading extension: ms-vscode.js-debug@1.60.0 ...
[08:40:49] Downloading extension: ms-vscode.vscode-js-profile-table@0.0.18 ...
[08:40:55] Finished bundle-marketplace-extensions-build after 8727 ms
[08:40:55] Starting compile-extensions-build ...
[08:40:55] Finished compile-extensions-build after 0 ms
[08:40:55] Starting clean-out-vscode ...
[08:40:55] Finished clean-out-vscode after 6 ms
[08:40:55] Starting optimize-vscode ...
[08:42:13] Finished optimize-vscode after 77611 ms
[08:42:13] Starting clean-vscode-linux-x64 ...
[08:42:13] Finished clean-vscode-linux-x64 after 9 ms
[08:42:13] Starting vscode-linux-x64-ci ...
[08:42:23] 'vscode-linux-x64' errored after 8.75 min
[08:42:23] Error: EACCES: permission denied, mkdir '/workspaces/VSCode-linux-x64'
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

You can work around it by running sudo chown node:node /workspaces first. Maybe the dev container should have that command in its Dockerfile?

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• Warning: Duplicate definition of module 'xyz' (#115013)

[Chuxel]

@chrmarti It looks like the build script is trying to create a folder that is a peer of the workspace which is odd. Is that actually expected? Also, isn't the workspace folder path created by Remote - Containers and normally has the right privs?

[Chuxel]

Added a chown there to the postCreateCommand - but I'm not sure if this is a new problem.

[chrmarti]

I agree, this looks like an older problem. Good to close for me when you add the chown.

[Chuxel]

@chrmarti Shouldn't /workspaces already have the right privs though?

[chrmarti]

We are using the default ownership for bind mounts there. We do update the ownership of the workspace's parent folder when using a volume and we could do the same here.