Skip to content

Fix broken debugging in codespaces #133232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sandy081 merged 1 commit into from
Sep 16, 2021
Merged

Fix broken debugging in codespaces #133232

sandy081 merged 1 commit into from
Sep 16, 2021

Conversation

@sandy081
Copy link
Member

@sandy081 sandy081 commented Sep 16, 2021

Fix #133178

@sandy081 sandy081 added this to the August 2021 Recovery 2 milestone Sep 16, 2021
@sandy081 sandy081 requested a review from isidorn September 16, 2021 08:50
@sandy081 sandy081 self-assigned this Sep 16, 2021
@isidorn
Copy link
Collaborator

isidorn commented Sep 16, 2021

Code changes look good, and Rob verified this fixes the debug issue -> approved.
I can also test this out in more detail once we have a build out. Let me know if you have some corner cases that should be tried out.

@sandy081 sandy081 merged commit b94937a into release/1.60 Sep 16, 2021
@sandy081 sandy081 deleted the sandy081/fix133178 branch September 16, 2021 09:14
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@isidorn isidorn isidorn approved these changes

Assignees

@sandy081 sandy081

Labels

None yet

Projects

None yet

Milestone

August 2021 Recovery 2

Development

Successfully merging this pull request may close these issues.

3 participants

@sandy081 @isidorn