Skip to content

Fix appHost being improperly defined#135387

Merged
joaomoreno merged 2 commits intorelease/1.61from
lramos15/appHostCandidate
Oct 19, 2021
Merged

Fix appHost being improperly defined#135387
joaomoreno merged 2 commits intorelease/1.61from
lramos15/appHostCandidate

Conversation

@lramos15
Copy link
Member

@lramos15 lramos15 commented Oct 19, 2021

On web appHost would always be 'web' regardless of embedderIdentifier. This is due to order of operations anda mistake I made with ternaries within || statements.

@lramos15 lramos15 added bug Issue identified by VS Code Team member as probable bug api candidate Issue identified as probable candidate for fixing in the next release labels Oct 19, 2021
@lramos15 lramos15 added this to the September 2021 Recovery 2 milestone Oct 19, 2021
@lramos15 lramos15 self-assigned this Oct 19, 2021
@joaomoreno joaomoreno self-requested a review October 19, 2021 14:41
@joaomoreno joaomoreno merged commit 6cba118 into release/1.61 Oct 19, 2021
@joaomoreno joaomoreno deleted the lramos15/appHostCandidate branch October 19, 2021 14:41
@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants