Skip to content

Conversation

@bpasero
Copy link
Member

@bpasero bpasero commented Jun 28, 2022

This PR fixes #

@bpasero bpasero enabled auto-merge (squash) June 28, 2022 05:03
@bpasero bpasero requested a review from jrieken June 28, 2022 05:03
bpasero referenced this pull request Jun 28, 2022
…flicts (#153341)

* auto save -> only inform about not resolved all conflicts yet
* manual save -> inform but also enable to discard

related to #151040 (comment)
@vscodenpa vscodenpa added this to the June 2022 milestone Jun 28, 2022
@bpasero
Copy link
Member Author

bpasero commented Jun 28, 2022

A new consequence of this change is the following error when selecting "Do not save":

ERR Model is disposed!: Error: Model is disposed!
    at TextModel._assertNotDisposed (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/editor/common/model/textModel.js:243:23)
    at TextModel.getLineMaxColumn (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/editor/common/model/textModel.js:571:18)
    at isAtEndOfLine (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/workbench/contrib/mergeEditor/browser/model/diffComputer.js:102:32)
    at normalizeRangeMapping (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/workbench/contrib/mergeEditor/browser/model/diffComputer.js:72:43)
    at rangeMappingFromCharChange (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/workbench/contrib/mergeEditor/browser/model/diffComputer.js:64:16)
    at vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/workbench/contrib/mergeEditor/browser/model/diffComputer.js:54:59
    at Array.map (<anonymous>)
    at fromLineChange (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/workbench/contrib/mergeEditor/browser/model/diffComputer.js:54:50)
    at vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/workbench/contrib/mergeEditor/browser/model/diffComputer.js:30:46
    at Array.map (<anonymous>)
    at Function.fromDiffComputationResult (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/workbench/contrib/mergeEditor/browser/model/diffComputer.js:30:35)
    at EditorWorkerServiceDiffComputer.computeDiff (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/workbench/contrib/mergeEditor/browser/model/diffComputer.js:27:61)
    at async TextModelDiffs.update (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/workbench/contrib/mergeEditor/browser/model/textModelDiffs.js:42:28)

@jrieken
Copy link
Member

jrieken commented Jun 28, 2022

@bpasero can you clarify? will the workbench revert the changes? The goal is that with "auto save: off" and users selecting "don't save" everything is undone to their state on disk

@bpasero
Copy link
Member Author

bpasero commented Jun 28, 2022

@jrieken yeah we revert here based on the result of confirm:

// first try a normal revert where the contents of the editor are restored
await editor.revert(this.id);

@bpasero bpasero merged commit 7233eff into main Jun 28, 2022
@bpasero bpasero deleted the ben/light-mole branch June 28, 2022 07:13
@github-actions github-actions bot locked and limited conversation to collaborators Aug 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants