Stat all folders and files within appRoot as readonly (#138815) #158185
Conversation
|
/assign @bpasero |
| local.updateName(disk.name); | ||
| } | ||
| local._isDirectory = disk.isDirectory; | ||
| local._readonly = disk._readonly; |
There was a problem hiding this comment.
In the end this change wasn't necessary to make this PR work, but it looked like an omission so I have left it in. @bpasero what do you think?
|
Submitting the PR has revealed that I've broken layering rules in the way I made Explorer work out whether to force metadata resolution so it gets to know when folders and files are read-only. @bpasero please advise whether there's another way to achieve this. |
|
To avoid the layer breaker I have made Explorer get metadata for all file:// uris. |
|
Thanks, will review when I find time for it. @lramos15 fyi for explorer changes. |
|
Added a warning notification when workspace opens, similar to the one the previous PR had per-file:
|
|
Sorry, will probably not have a lot of time this month, might push this back a bit. |
|
@gjsjohnmurray I am not easy accepting this change, especially forcing How about a different approach where we simply open a notification if a user opens the installation dir or any child of that as a workspace folder? We could even leverage the banner for this to make it more prominent:
Maybe it could also be a modal dialog to be very annoying. |
2 participants
Second attempt at resolving #138815 to reduce the likelihood of a naive user storing their projects within the appRoot folder and then being upset when a VS Code update deletes their files.
This PR implements @bpasero's suggestion at #155443 (comment) but also makes Explorer play nice.