Skip to content

Conversation

@Tyriar
Copy link
Member

@Tyriar Tyriar commented Aug 31, 2022

Part of #156864

Discussion about this in b52be01. This doesn't seem to impact the terminal start up experience, at least on my machine.

cc @meganrogge

@Tyriar Tyriar added this to the September 2022 milestone Aug 31, 2022
@Tyriar Tyriar requested a review from bpasero August 31, 2022 12:18
@Tyriar Tyriar self-assigned this Aug 31, 2022
Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 🚀

@Tyriar Tyriar enabled auto-merge August 31, 2022 12:24
@Tyriar Tyriar merged commit 861eff6 into main Aug 31, 2022
@Tyriar Tyriar deleted the tyriar/156864 branch August 31, 2022 12:32
@Tyriar
Copy link
Member Author

Tyriar commented Sep 1, 2022

This ended up causing a regression to reconnect:

ERR Cannot get default system shell when there is no backend for remote authority 'undefined': Error: Cannot get default system shell when there is no backend for remote authority 'undefined'
    at Object.getDefaultSystemShell (vscode-file://vscode-app/c:/Github/microsoft/vscode/out/vs/workbench/contrib/terminal/electron-sandbox/terminalProfileResolverService.js:24:31)
    at ElectronTerminalProfileResolverService._getUnresolvedFallbackDefaultProfile (vscode-file://vscode-app/c:/Github/microsoft/vscode/out/vs/workbench/contrib/terminal/browser/terminalProfileResolverService.js:240:52)
    at ElectronTerminalProfileResolverService._getUnresolvedDefaultProfile (vscode-file://vscode-app/c:/Github/microsoft/vscode/out/vs/workbench/contrib/terminal/browser/terminalProfileResolverService.js:186:67)
    at async ElectronTerminalProfileResolverService.getDefaultProfile (vscode-file://vscode-app/c:/Github/microsoft/vscode/out/vs/workbench/contrib/terminal/browser/terminalProfileResolverService.js:137:41)
    at async vscode-file://vscode-app/c:/Github/microsoft/vscode/out/vs/workbench/contrib/terminal/browser/terminalInstance.js:225:45

@Tyriar
Copy link
Member Author

Tyriar commented Sep 1, 2022

#159761

@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants