Enable autoplay in webviews #165784
Merged
Enable autoplay in webviews #165784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For microsoft#134514 This PR allows autoplaying of audio/videos in webviews. However it disables autoplaying of non-muted audio/video without user interaction by setting `autoplayPolicy` in electron. Browsers automatically follow the same behavior
mjbvz
commented
Nov 8, 2022
| const allowRules = ['cross-origin-isolated;']; | ||
| const allowRules = ['cross-origin-isolated', 'autoplay']; | ||
| if (!isFirefox) { | ||
| allowRules.push('clipboard-read;', 'clipboard-write;'); |
Collaborator
Author
There was a problem hiding this comment.
The old code seemed like a bug since it was always setting allow twice
rebornix
approved these changes
Nov 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #134514
This PR allows autoplaying of audio/videos in webviews. However it disables autoplaying of non-muted audio/video without user interaction by setting
autoplayPolicyin electron. Browsers automatically follow the same behavior