Disable passing in locale to Electron on macOS #167889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepak1556
reviewed
Dec 2, 2022
Co-authored-by: Robo <hop2deep@gmail.com>
deepak1556
approved these changes
Dec 2, 2022
deepak1556
added
the
candidate
sbatten
approved these changes
Dec 2, 2022
Member
|
This now needs to be merged to the release branch as well |
sbatten
pushed a commit
that referenced
this pull request
Dec 2, 2022
* Disable passing in locale to Electron on macOS Fixes #167543 * Update src/main.js Co-authored-by: Robo <hop2deep@gmail.com> * Fix comment and apply PR feedback Co-authored-by: Robo <hop2deep@gmail.com>
sbatten
added a commit
that referenced
this pull request
Dec 2, 2022
* Disable passing in locale to Electron on macOS Fixes #167543 * Update src/main.js Co-authored-by: Robo <hop2deep@gmail.com> * Fix comment and apply PR feedback Co-authored-by: Robo <hop2deep@gmail.com> Co-authored-by: Raymond Zhao <7199958+rzhao271@users.noreply.github.com> Co-authored-by: Robo <hop2deep@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #167543
This fix reverts the behaviour back to #164397, which is also buggy, but is not as bad, because with the old buggy behaviour, the user could at least see all the traffic light buttons.