Tabs: do not redraw when same editor opens (fix #164666) #168823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpasero
changed the title
This was referenced Dec 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will prevent redraw all tabs and
breadcrumbsControl.updateif the active editor did not change as requested in #164666.@jrieken can you see the changes for breadcrumbs. since we no longer call
updatefor breadcrumbs, we now may loose functionality we had before. Specifically there seems to be revealing of the item here:vscode/src/vs/workbench/browser/parts/editor/breadcrumbsControl.ts
Line 315 in 40d25a1
But the
updatemethod is long, so would be good for a second look from you to avoid regressions.