joh/startupPerf #169751
Merged
joh/startupPerf #169751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…voked 4 times - twice per `defaultConfigurations` and `configuration` contribution
…ly faster than the value but more importantly will reduce GC pressure because the TST does look ups without allocating make `affectedKeys` a `ReadonlySet` (which is faster than using array.indexOf) but also migrate most listeners onto `affectsConfiguration` which is even faster add `hasElementOrSubtree` to TST
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to help with #168639. I saw a slight uptick for the time it takes to handle the configuration defaults contribution point. Therefore I profiled this a bit and created this PR. It's collection of tiny improvements in the hunt of a millisecond here and there. The biggest changes are around the configuration change event - on my machine its faster by around 1 to 2ms (which is 10x on the perf bot) but getting confidence in the measurements are hard and maybe flukes.
onDidSchemaChangeevent per registerDefaultConfiguration-callregisterConfigurationSchemaslistening, before this was invoked 4 times - twice perdefaultConfigurationsandconfigurationcontributionConfigurationChangeEventThis is slightly faster than the value-tree but more importantly will reduce GC pressure because the TST does lookups without allocatingIConfigurationChangeEvent#affectedKeysso that folks stop doingindexOf. Also migrated most user to theaffectsConfigurationfunction