Skip to content

Conversation

@Aaaaash
Copy link
Contributor

@Aaaaash Aaaaash commented Feb 2, 2023

Fixes: #169268

@hediet
Copy link
Member

hediet commented Feb 2, 2023

Can you look into the failing tests? Thanks!

@hediet hediet added this to the February 2023 milestone Feb 2, 2023
@Aaaaash Aaaaash force-pushed the fix/register-language-perf branch 2 times, most recently from 86f23cd to 47bcefc Compare February 8, 2023 02:53
@hediet hediet modified the milestones: February 2023, March 2023 Feb 20, 2023
@hediet hediet modified the milestones: March 2023, April 2023 Mar 20, 2023
@Aaaaash Aaaaash force-pushed the fix/register-language-perf branch from b24aa7a to 8601ba8 Compare April 7, 2023 06:49
@Aaaaash Aaaaash force-pushed the fix/register-language-perf branch from 8601ba8 to 2b3b36c Compare April 7, 2023 06:55
@Aaaaash Aaaaash force-pushed the fix/register-language-perf branch from eff0018 to 43196fc Compare April 7, 2023 09:52
@hediet
Copy link
Member

hediet commented Apr 13, 2023

Thanks for the PR!
I'm not sure it is working in all the cases. In particular, unregistering doesn't work with this.

@hediet hediet modified the milestones: April 2023, May 2023 Apr 13, 2023
@hediet hediet modified the milestones: May 2023, June 2023 May 26, 2023
@hediet hediet modified the milestones: June 2023, Backlog, July 2023 Jun 27, 2023
@hediet hediet assigned alexdima and unassigned hediet Jul 11, 2023
@alexdima
Copy link
Member

Thank you, we ended up with a slightly different approach in #187881

@alexdima alexdima closed this Jul 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Monaco Editor: languageRegistry._registerLanguage method is called too many times

3 participants