feat: Go to Match on click of matches count #172127 #174075
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Viijay-Kr
force-pushed
the
feat-#172127-go-to-match-more-discoverable
branch
from
92994ac to
d78de17
Compare
Contributor
|
@rebornix please add this to a milestone. |
Contributor
|
@rebornix please don't lose sight of this community contribution. |
Collaborator
|
The styling needs to be updated to better match the other parts of the UI - height should match the neighboring button, don't add extra left padding
|
Member
|
I like this prototype but considering that it's a relatively large UX change (making the result label actionable), I'm closing this for now and will pick it up again when we start some UX unification for the find widget (e.g., supporting multiple search/find scope). Thanks again for your contribution. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #172127