Try to optimize ContextKeyService.updateParent #178077
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that `ContextKeyService.updateParent` was taking ~5ms, which is a problem if it happens during scrolling This PR reduces it's cost by doing the following: - Skip the call entirely if we already have the correct parent - Don't re-spread objects in `collectAllValues` - Return iterator directly instead of yield*ing it
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that
ContextKeyService.updateParentwas taking ~5ms, which causes jitter if it happens during scrolling in the interactive viewThis PR reduces it's cost by doing the following:
Skip the call entirely if we already have the correct parent
Don't re-spread objects in
collectAllValuesReturn iterator directly instead of yield*ing it