Skip to content

delete unused fish file #179392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
meganrogge merged 3 commits into from
Apr 7, 2023
Merged

delete unused fish file #179392

meganrogge merged 3 commits into from
Apr 7, 2023

Conversation

@meganrogge
Copy link
Contributor

@meganrogge meganrogge commented Apr 6, 2023

fix #179353

@meganrogge meganrogge self-assigned this Apr 6, 2023
@meganrogge meganrogge requested a review from Tyriar April 6, 2023 14:23
@meganrogge meganrogge added this to the April 2023 milestone Apr 6, 2023
@meganrogge meganrogge enabled auto-merge April 6, 2023 14:28
Tyriar
Tyriar reviewed Apr 6, 2023
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit hard to see what's going on in this diff, but I don't think the original file is being deleted?

image

I forgot why this file exists, is it referenced by docs or the CLI or fish docs or something?

@meganrogge
Copy link
Contributor Author

meganrogge commented Apr 6, 2023

from the PR, fish expects this script to be in this location, but we want it with the other scripts, so this is just a pointer to that. we could instead just move our shell integration script inside this file

@Tyriar
Copy link
Member

Tyriar commented Apr 6, 2023

I think the previous one was a symlink but the new one isn't?

Screenshot 2023-04-06 at 11 44 43 am

@Tyriar
Copy link
Member

Tyriar commented Apr 6, 2023

The docs say to run this which points at the actual script:

Screenshot 2023-04-06 at 11 46 28 am

https://code.visualstudio.com/docs/terminal/shell-integration

I'm not sure this file does anything? 😕

@meganrogge
Copy link
Contributor Author

meganrogge commented Apr 6, 2023

Yeah you're right - I had assumed that was doing something. I deleted the file and it still works

@meganrogge meganrogge changed the title move fish shell integration script delete unused fish file Apr 7, 2023
@meganrogge meganrogge merged commit 764face into main Apr 7, 2023
@meganrogge meganrogge deleted the merogge/fish branch April 7, 2023 14:42
@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@meganrogge meganrogge

Labels

None yet

Projects

None yet

Milestone

April 2023

Development

Successfully merging this pull request may close these issues.

Strange workbench contrib src/vs/workbench/contrib/xdg_data/fish

3 participants

@meganrogge @Tyriar