Accessibility help dialog uses semantic markup for assistive technology #179726
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change converts the accessibility help dialog to use correct markup for assistive technology / screen readers. This work was mentioned in #179689 and so I'm associating that here.
The modal dialog now uses
aria-modaland is labeled byaria-labelledbywhich points to theh1element within the modal.aria-describedbypoints to the text content of the dialog, as is optionally part of the dialog pattern.The content of the dialog has the
documentrole but does not has anaria-labelas it is not required for this element, but an aria label is required for thedialogrole per https://w3c.github.io/aria/#dialog.List markup is used to identify list elements rather than plain text.
Focus points to the dialog text content as per the aria APG example but could focus the heading instead for better support in VoiceOver in particular, which doesn't announce the dialog title implicitly, unlike JAWS and NVDA.
Questions to the reviewer:
$jquery style element creation or FastDomNode everywhere.H1elements which should be used for the heading. If you have style recommendations or an existing style which should be recommended, please let me know.Web app:
Electron app: