Allow display:inline-block on spans style #180498
Conversation
|
Pinging @mjbvz who might have an opinion about this change. |
|
@mjbvz Hey Matt, |
|
This oneliner fixes the only missing feature of ts-pretty-errors. Could someone take a look? Looks like one year should have been enough time for reviewing this simple fix. |
|
Hello @mjbvz and @gjsjohnmurray. It has been nearly 1.5 years since this PR was opened. Are there any further reservations about merging this in? This enables a fix for #180496, which will enable a massive developer experience improvement for the Pretty TS Errors plugin. What are the steps we can take to get this prioritized and possibly merged? This would enable a huge improvement to the DX for nearly one million developer using this plugin. |
|
Any chance of merging this PR @mjbvz ? |
|
Hello! @mjbvz could you please check this out? This would be awesome for empowering extension developers. |
|
There's now a little conflit, yoavbls. Let's resolve it and give it another bump. TY! :-) |
yoavbls
force-pushed
the
allow-display-prop-in-spans-style
branch
from
91e8c53 to
6a26c24
Compare
yoavbls
changed the title
|
@mbtools updated, now allowing only inline-block to make it even safer |
|
LGTM 👍 |
|
👀👀 |
|
+1, still relevant |
|
WoW, not even a reply to say they hated the solution or that the solution conflicts with their personal preferences and will not be merged? This can easily impact millions of developers (me included) to a better experience and not a single word for years? Shame. |
|
Since Microsoft / The Assignee / The Reviewer has been silent on this pr for a long time ... Does anyone know how to, instead, remove the original errors, and only show the Pretty TypeScript Errors ? |
14 participants
Solves #180496