Measure and report basic terminal performance marks #185668
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #185393
@jrieken changes to timer service:
LifecyclePhase.Restored. I also looked into including terminal stats inIStartupMetrics.timersbut that's a layer breaker.Example output below which shows
getTerminalLayoutinfo and the firstrecreateTerminaltake a long time, the latter is quite unexpected.Raw Perf Marks: terminal