Improve error messages to users where encryption fails/isn't available #186037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses new Electron APIs that @deepak1556 has added to our Electron build. I've also tested to make sure that those APIs are properly gated to not break OSS.
bpasero
approved these changes
Jun 25, 2023
deepak1556
reviewed
Jun 26, 2023
| } else if (isKwallet(provider)) { | ||
| errorMessage = localize('isKwallet', "You're running in a KDE environment but encryption is not available. Ensure you have kwallet running."); | ||
| } else if (provider === KnownStorageProvider.basicText) { | ||
| errorMessage += ' ' + localize('usePlainTextExtraSentence', "Open the troubleshooting guide or you can use plain text obfuscation instead."); |
Collaborator
There was a problem hiding this comment.
An average user might not know what plain text obfuscation would be ? Maybe a better wording would be
An OS keyring couldn't be identified for storing the encryption related data in your current
desktop environment, please open the troubleshooting guide to address this or you can use
a in-memory based weaker encryption.
gjsjohnmurray
pushed a commit
to gjsjohnmurray/vscode
that referenced
this pull request
Jun 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses new Electron APIs that @deepak1556 has added to our Electron build. I've also tested to make sure that those APIs are properly gated to not break OSS.