Skip to content

Conversation

@wise0704
Copy link

Related: dotnet/vscode-csharp#5030

Textmate scope for target-typed new keyword is currently classified incorrectly as a method call.

@alexr00
Copy link
Member

alexr00 commented Jul 25, 2023

Thank you for the PR, please see the info for contributors:

"information_for_contributors": [
"This file has been converted from https://github.com/dotnet/csharp-tmLanguage/blob/master/grammars/csharp.tmLanguage",
"If you want to provide a fix or improvement, please create a pull request against the original repository.",
"Once accepted there, we are happy to receive an update request."

@alexr00 alexr00 closed this Jul 25, 2023
@wise0704
Copy link
Author

wise0704 commented Jul 25, 2023

Thank you for the PR, please see the info for contributors:

"information_for_contributors": [
"This file has been converted from https://github.com/dotnet/csharp-tmLanguage/blob/master/grammars/csharp.tmLanguage",
"If you want to provide a fix or improvement, please create a pull request against the original repository.",
"Once accepted there, we are happy to receive an update request."

Sorry. I noticed only after making the PR.
In case anyone is interested, an equivalent PR is made in dotnet/csharp-tmLanguage#258

@wise0704 wise0704 deleted the patch-1 branch July 25, 2023 13:12
@alexr00
Copy link
Member

alexr00 commented Jul 25, 2023

Once the PR is merged there I will pull the updates into VS Code.

@alexr00
Copy link
Member

alexr00 commented Jul 26, 2023

I see that the PR is merged. We are in the middle of our endgame week now though, which means I should wait until we're done to pull in the changes.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants