fix: devcontainer cache generation pipeline with Electron v25

[deepak1556]

Addresses the failure seen in https://github.com/microsoft/vscode/actions/runs/5785283604/job/15678095549

[deepak1556]

Validation run https://github.com/microsoft/vscode/actions/runs/5791161324/job/15695513940

Need to update mcr.microsoft.com/vscode/devcontainers/repos/microsoft/vscode:dev to use Node.js v18, @chrmarti should I send a PR to bump the version in https://github.com/microsoft/vscode-dev-containers/blob/main/repository-containers/images/github.com/microsoft/vscode/.devcontainer/base.Dockerfile ? I see the repo is getting archived but I don't see a corresponding image in https://github.com/devcontainers/images/tree/main/src, so not sure where to direct the PR.

[deepak1556]

@chrmarti is currently on vacation. @bamurtaugh can you clarify the above question, thanks!

[bamurtaugh]

should I send a PR to bump the version in https://github.com/microsoft/vscode-dev-containers/blob/main/repository-containers/images/github.com/microsoft/vscode/.devcontainer/base.Dockerfile

Yes, please go ahead and send a PR to vscode-dev-containers, thanks @deepak1556!

cc @samruddhikhandale @alexdima I believe we still need to determine where to move the prebuilt VS Code image, but we should continue updating it in vscode-dev-containers at the moment. Please let me know if I'm forgetting anything.

[deepak1556]

Thanks @bamurtaugh , PR at microsoft/vscode-dev-containers#1764

[deepak1556]

New run https://github.com/microsoft/vscode/actions/runs/5811776948/job/15766874284 confirmed that node-gyp missing error is addressed, but now there are errors in downloading playwright that is unrelated to the Electron update. @chrmarti passing this on to you since it requires changes in the container disk configuration.

/repo-source-tmp/node_modules/playwright/node_modules/playwright-core/lib/server/registry/index.js:644
#14 2465.3       throw new Error(`Failed to download ${title}, caused by\n${e.stack}`);
#14 2465.3             ^
#14 2465.3 
#14 2465.3 Error: Failed to download Chromium 110.0.5481.38 (playwright build v1045), caused by
#14 2465.3 Error: ENOSPC: no space left on device, write
#14 2465.3     at /repo-source-tmp/node_modules/playwright/node_modules/playwright-core/lib/server/registry/index.js:644:13

[chrmarti]

We removed the cache generation image. Closing.