Skip to content

Restore version check (#190042) #190074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joyceerhl merged 2 commits into from
Aug 9, 2023
Merged

Restore version check (#190042) #190074

joyceerhl merged 2 commits into from
Aug 9, 2023

Conversation

@bpasero
Copy link
Member

@bpasero bpasero commented Aug 9, 2023 •
edited by alexr00
Loading

Fixes #189877

@bpasero bpasero self-assigned this Aug 9, 2023
@bpasero bpasero added the candidate Issue identified as probable candidate for fixing in the next release label Aug 9, 2023
@bpasero bpasero requested a review from joyceerhl August 9, 2023 18:40
@bpasero bpasero added this to the July 2023 Recovery 1 milestone Aug 9, 2023
@joyceerhl joyceerhl enabled auto-merge (squash) August 9, 2023 20:23
@joyceerhl joyceerhl merged commit 9ca413b into release/1.81 Aug 9, 2023
@joyceerhl joyceerhl deleted the ben/modern-goat branch August 9, 2023 20:40
alexr00
alexr00 approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have also verified that #188582 (the version check was removed to fix this) is still fixed in insiders.

@joyceerhl joyceerhl mentioned this pull request Aug 10, 2023
Closed
@sandy081 sandy081 mentioned this pull request Aug 21, 2023
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alexr00 alexr00 alexr00 approved these changes

+1 more reviewer

@joyceerhl joyceerhl joyceerhl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bpasero bpasero

Labels

candidate Issue identified as probable candidate for fixing in the next release

Projects

None yet

Milestone

July 2023 Recovery 1

Development

Successfully merging this pull request may close these issues.

5 participants

@bpasero @joyceerhl @alexr00 @alexdima